Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(split): use configuration-observability-oss, removed xService #127

Merged
merged 2 commits into from
Nov 4, 2023
Merged

feat(split): use configuration-observability-oss, removed xService #127

merged 2 commits into from
Nov 4, 2023

Conversation

haarchri
Copy link
Member

@haarchri haarchri commented Nov 1, 2023 •
edited
Loading

Description of your changes

  • use configuration-observability-oss
  • use configuration-gitops-flux
  • removed xService

Fixes #114

I have:

  • Read and followed Upbound's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR, as appropriate.

How has this code been tested

--- PASS: kuttl (2382.59s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/case (2382.10s)
PASS
15:06:02 [ OK ] running automated tests

@haarchri
feat(split): prometheus and gitops
c960e09 
Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
@haarchri haarchri force-pushed the feature/finish-split branch from 874b21e to c960e09 Compare November 4, 2023 14:08
@haarchri haarchri marked this pull request as ready for review November 4, 2023 14:09
@haarchri
Copy link
Member Author

haarchri commented Nov 4, 2023

/test-examples

ytsarev
ytsarev approved these changes Nov 4, 2023
View reviewed changes
Copy link
Member

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great! Just left one trailing whitespace bust :)

apis/cluster/definition.yaml Outdated Show resolved Hide resolved
@haarchri
style(white): remove whitespace
19fb0a5 
Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
@haarchri haarchri merged commit 619de82 into upbound:main Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ytsarev ytsarev ytsarev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XServices should only contain 1 helm release
2 participants
@haarchri @ytsarev